[PATCH] D55740: Fix sanitizer tool list used to generate sanitizer_common tests to be up-to-date.

[Dan Liew via Phabricator via llvm-commits]

delcypher marked 3 inline comments as done.
delcypher added inline comments.


================
Comment at: test/sanitizer_common/CMakeLists.txt:18
+    if (COMPILER_RT_HAS_${SANITIZER_TOOL_UPPER})
+      list(APPEND SUPPORTED_TOOLS ${SANITIZER_TOOL})
+    endif()
----------------
vitalybuka wrote:
> # Remove: "if (NOT (ANDROID OR WINDOWS))"
> # Create the list
> # Print the list
> #  for windows and android:
>   - replace the list and with hardcoded one
>   - print the new list and with some FIXME warning about this replacement
@vitalybuka I've updated the patch with what (I think) you asked for.


================
Comment at: test/sanitizer_common/TestCases/symbolize_stack.cc:6
+// FIXME(dliew): Make this test work with the other sanitizers.
+// UNSUPPORTED: darwin && (lsan || tsan || ubsan)
+
----------------
vitalybuka wrote:
> why is this not XFAIL? 
I think the original reason was the for LSan on i386 it would hang (crashed while doing stop-the-world). However because I prevent those tests being run from `ninja check-sanitizer` in the `CMakeLists.txt` file, using `XFAIL`, is probably okay.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55740/new/

https://reviews.llvm.org/D55740