[PATCH] D56501: [WebAssembly] Add unimplemented-simd128 subtarget feature

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 9 11:28:39 PST 2019


tlively marked an inline comment as done.
tlively added inline comments.


================
Comment at: test/CodeGen/WebAssembly/simd-arith.ll:127
+; SIMD128-NEXT: i32.shr_s $push[[L2:[0-9]+]]=, $pop[[L0]], $pop[[L1]]{{$}}
+; SIMD128-NEXT: i8x16.splat $push[[L3:[0-9]+]]=, $pop[[L2]]{{$}}
 ; Skip 14 lanes
----------------
aheejin wrote:
> Why are there changes in the test results in this file?
Probably because the new implicit enabling of the sign-ext feature made sign_ext_inreg legal, which led to the explicit selection of extract_lane_s. Before extract_lane_s was being selected only because it was the default for an any_extend, which was then sign extended via the shifts.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56501/new/

https://reviews.llvm.org/D56501





More information about the llvm-commits mailing list