[PATCH] D56501: [WebAssembly] Add unimplemented-simd128 subtarget feature

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

I thought the unimplemented SIMD thing is a temporary workaround. Are they not planned to be implemented in V8 for a long time so that we should make it as a feature?



================
Comment at: lib/Target/WebAssembly/WebAssembly.td:32
 def FeatureSIMD128 : SubtargetFeature<"simd128", "HasSIMD128", "true",
-                                      "Enable 128-bit SIMD">;
+                                      "Enable 128-bit SIMD", [FeatureSignExt]>;
+
----------------
Didn't know we can specify dependences in features! Cool.


================
Comment at: test/CodeGen/WebAssembly/simd-arith.ll:127
+; SIMD128-NEXT: i32.shr_s $push[[L2:[0-9]+]]=, $pop[[L0]], $pop[[L1]]{{$}}
+; SIMD128-NEXT: i8x16.splat $push[[L3:[0-9]+]]=, $pop[[L2]]{{$}}
 ; Skip 14 lanes
----------------
Why are there changes in the test results in this file?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56501/new/

https://reviews.llvm.org/D56501