[PATCH] D55919: [DebugInfo] Omit location list entries with empty ranges

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 7 06:50:20 PST 2019


dstenb marked an inline comment as done.
dstenb added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1188
+      // variable.
+      if (DIExpr->isFragment())
+        OpenRanges.push_back(Value);
----------------
aprantl wrote:
> why not just move the condition two lines further down?
Sorry for the late response due to the holiday season!

I'm not sure I follow. Do you mean to merge this code with the `DIExpr->isFragment()` code at line 1198 somehow?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55919/new/

https://reviews.llvm.org/D55919





More information about the llvm-commits mailing list