[llvm] r350402 - Revert patches 348835 and 348571 because they're

[Ranjeet Singh via llvm-commits]

Author: rsingh
Date: Fri Jan  4 08:39:10 2019
New Revision: 350402

URL: http://llvm.org/viewvc/llvm-project?rev=350402&view=rev
Log:
Revert patches 348835 and 348571 because they're
causing code size performance regressions.


Added:
    llvm/trunk/test/Assembler/2004-03-07-FunctionAddressAlignment.ll
      - copied unchanged from r348570, llvm/trunk/test/Assembler/2004-03-07-FunctionAddressAlignment.ll
Removed:
    llvm/trunk/test/Analysis/ConstantFolding/func-and-folding.ll
Modified:
    llvm/trunk/lib/IR/ConstantFold.cpp

Modified: llvm/trunk/lib/IR/ConstantFold.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/ConstantFold.cpp?rev=350402&r1=350401&r2=350402&view=diff
==============================================================================
--- llvm/trunk/lib/IR/ConstantFold.cpp (original)
+++ llvm/trunk/lib/IR/ConstantFold.cpp Fri Jan  4 08:39:10 2019
@@ -27,7 +27,6 @@
 #include "llvm/IR/GlobalAlias.h"
 #include "llvm/IR/GlobalVariable.h"
 #include "llvm/IR/Instructions.h"
-#include "llvm/IR/Module.h"
 #include "llvm/IR/Operator.h"
 #include "llvm/IR/PatternMatch.h"
 #include "llvm/Support/ErrorHandling.h"
@@ -1078,10 +1077,10 @@ Constant *llvm::ConstantFoldBinaryInstru
             isa<GlobalValue>(CE1->getOperand(0))) {
           GlobalValue *GV = cast<GlobalValue>(CE1->getOperand(0));
 
-          unsigned GVAlign =
-              GV->getParent()
-                  ? GV->getPointerAlignment(GV->getParent()->getDataLayout())
-                  : 0;
+          // Functions are at least 4-byte aligned.
+          unsigned GVAlign = GV->getAlignment();
+          if (isa<Function>(GV))
+            GVAlign = std::max(GVAlign, 4U);
 
           if (GVAlign > 1) {
             unsigned DstWidth = CI2->getType()->getBitWidth();

Removed: llvm/trunk/test/Analysis/ConstantFolding/func-and-folding.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Analysis/ConstantFolding/func-and-folding.ll?rev=350401&view=auto
==============================================================================
--- llvm/trunk/test/Analysis/ConstantFolding/func-and-folding.ll (original)
+++ llvm/trunk/test/Analysis/ConstantFolding/func-and-folding.ll (removed)
@@ -1,27 +0,0 @@
-; RUN: opt < %s -constprop -S -o - | FileCheck %s
-
-; Function Attrs: minsize norecurse nounwind optsize readnone
-define void @foo1() #0 {
-entry:
-  ret void
-}
-
-; Function Attrs: minsize norecurse nounwind optsize readnone
-define void @foo2() align 4 {
-entry:
-  ret void
-}
-
-; Function Attrs: minsize nounwind optsize
-define i32 @main() local_unnamed_addr #1 {
-entry:
-; CHECK: ptrtoint
-  %call = tail call i32 bitcast (i32 (...)* @process to i32 (i32)*)(i32 and (i32 ptrtoint (void ()* @foo1 to i32), i32 2)) #3
-; CHECK-NEXT: ptrtoint
-  %call2 = tail call i32 bitcast (i32 (...)* @process to i32 (i32)*)(i32 and (i32 ptrtoint (void ()* @foo2 to i32), i32 2)) #3
-  ret i32 0
-}
-
-; Function Attrs: minsize optsize
-declare i32 @process(...) local_unnamed_addr #2
-