[PATCH] D56275: x86 interrupt calling convention: Fix argument offsets

Thu Jan 3 09:44:48 PST 2019

lebedev.ri added a comment.

In D56275#1345277 <https://reviews.llvm.org/D56275#1345277>, @phil-opp wrote:

> > Test?
>
> I tried to add additional checks to the `x86-64-intrcc.ll` test, but the patched version of `llc` generates the exact same assembly as the unpatched version for this test (with and without -O0). I think this is because the test doesn't use the relevant code paths. I'm not sure whether it's practical to construct new tests for every code path and how to construct such tests.

Either something is 'broken', and this patch fixes things, or the patch is not needed.

How do you know that this patch helps/does the right thing?
There is probably some code that now is not broken?
Can you write an automated check for that?
If yes, you could try to creduce/bugpoint that code to the minimal snippet that still shows the miscompile(?) fix.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56275/new/

https://reviews.llvm.org/D56275