[PATCH] D56275: x86 interrupt calling convention: Fix argument offsets

Philipp Oppermann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 3 09:40:28 PST 2019


phil-opp added a comment.

> Test?

I tried to add additional checks to the `x86-64-intrcc.ll` test, but the patched version of `llc` generates the exact same assembly as the unpatched version for this test (with and without -O0). I think this is because the test doesn't use the relevant code paths. I'm not sure whether it's practical to construct new tests for every code path and how to construct such tests.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56275/new/

https://reviews.llvm.org/D56275





More information about the llvm-commits mailing list