[PATCH] D30526: [Support] Add functions to get and set thread name.

Wed Jan 2 17:19:12 PST 2019

I don’t have much experience to submit patch to LLVM. Could you please help verify and make the change after you are back from vacation? Thanks in advance.

FYI: this issue was found when building swiftshader in Chromium for Windows ARM64.

From: Zachary Turner <zturner at google.com>
Sent: Wednesday, January 2, 2019 5:13 PM
To: Tom Tan <Tom.Tan at microsoft.com>
Cc: reviews+D30526+public+c109a870c771c88e at reviews.llvm.org; chandlerc at gmail.com; chris.bieneman at me.com; pavel at labath.sk; jfbastien at apple.com; notstina at gmail.com; n54 at gmx.com; dccitaliano at gmail.com; danalbert at google.com; srhines at google.com; emaste at freebsd.org; llvm-commits at lists.llvm.org; llvm at inglorion.net; sguelton at redhat.com
Subject: Re: [PATCH] D30526: [Support] Add functions to get and set thread name.

Sounds good.  Feel free to submit that patch then.  Thanks!

On Wed, Jan 2, 2019 at 5:12 PM Tom Tan <Tom.Tan at microsoft.com<mailto:Tom.Tan at microsoft.com>> wrote:
Thanks Zachary. Yes, exactly, it is that “Windows” folder needs to be removed from the include path for WindowsSupport.h because both Threading.inc and WindowsSupport.h are in the same “Windows” folder.

From: Zachary Turner <zturner at google.com<mailto:zturner at google.com>>
Sent: Wednesday, January 2, 2019 5:07 PM
To: reviews+D30526+public+c109a870c771c88e at reviews.llvm.org<mailto:reviews%2BD30526%2Bpublic%2Bc109a870c771c88e at reviews.llvm.org>
Cc: chandlerc at gmail.com<mailto:chandlerc at gmail.com>; chris.bieneman at me.com<mailto:chris.bieneman at me.com>; pavel at labath.sk<mailto:pavel at labath.sk>; jfbastien at apple.com<mailto:jfbastien at apple.com>; notstina at gmail.com<mailto:notstina at gmail.com>; Tom Tan <Tom.Tan at microsoft.com<mailto:Tom.Tan at microsoft.com>>; n54 at gmx.com<mailto:n54 at gmx.com>; dccitaliano at gmail.com<mailto:dccitaliano at gmail.com>; danalbert at google.com<mailto:danalbert at google.com>; srhines at google.com<mailto:srhines at google.com>; emaste at freebsd.org<mailto:emaste at freebsd.org>; llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>; llvm at inglorion.net<mailto:llvm at inglorion.net>; sguelton at redhat.com<mailto:sguelton at redhat.com>
Subject: Re: [PATCH] D30526: [Support] Add functions to get and set thread name.

I'm on vacation right now so I don't have a source tree that I can get access to, but if the two files are in the same directory then I think we shouldn't specify the folder name, and it should just be #include "WindowsSupport.h".  Let me know if I'm misunderstood the situation though.

On Wed, Jan 2, 2019 at 4:17 PM Tom Tan via Phabricator <reviews at reviews.llvm.org<mailto:reviews at reviews.llvm.org>> wrote:
TomTan added a comment.
Herald added subscribers: kristina, jfb.

Hi Zachary, does this line "#include "Windows/WindowsSupport.h" " need to be changed to "#include "WindowsSupport.h" " after it is moved from Threading.cpp to Threading.inc, because Threading.inc which includes WindowsSupport.h is under Windows folder, so no need to have it in the include path. This current include path could trigger warning "#include resolved using non-portable Microsoft search rules as: ..."

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D30526/new/<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD30526%2Fnew%2F&data=02%7C01%7CTom.Tan%40microsoft.com%7Cdfe74d7477b54b29d72108d67118abaa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636820748131392196&sdata=zLuT41MvdXmvkruKuTgFM7qo%2FqgnvI1DgAPmbWsx50s%3D&reserved=0>

https://reviews.llvm.org/D30526<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD30526&data=02%7C01%7CTom.Tan%40microsoft.com%7Cdfe74d7477b54b29d72108d67118abaa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636820748131392196&sdata=vXq4vX9NuYK0YmOcZtfC74KmkumWhJpJ7VSXFK15LW8%3D&reserved=0>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190103/0a326210/attachment-0001.html>