<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">I don’t have much experience to submit patch to LLVM. Could you please help verify and make the change after you are back from vacation? Thanks in advance.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">FYI: this issue was found when building swiftshader in Chromium for Windows ARM64.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><b>From:</b> Zachary Turner <zturner@google.com> <br>
<b>Sent:</b> Wednesday, January 2, 2019 5:13 PM<br>
<b>To:</b> Tom Tan <Tom.Tan@microsoft.com><br>
<b>Cc:</b> reviews+D30526+public+c109a870c771c88e@reviews.llvm.org; chandlerc@gmail.com; chris.bieneman@me.com; pavel@labath.sk; jfbastien@apple.com; notstina@gmail.com; n54@gmx.com; dccitaliano@gmail.com; danalbert@google.com; srhines@google.com; emaste@freebsd.org;
llvm-commits@lists.llvm.org; llvm@inglorion.net; sguelton@redhat.com<br>
<b>Subject:</b> Re: [PATCH] D30526: [Support] Add functions to get and set thread name.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Sounds good. Feel free to submit that patch then. Thanks!<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Wed, Jan 2, 2019 at 5:12 PM Tom Tan <<a href="mailto:Tom.Tan@microsoft.com">Tom.Tan@microsoft.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Thanks Zachary. Yes, exactly, it is that “Windows” folder needs to be removed from the include path for WindowsSupport.h because both Threading.inc and WindowsSupport.h are in the
same “Windows” folder. <o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b>From:</b> Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>>
<br>
<b>Sent:</b> Wednesday, January 2, 2019 5:07 PM<br>
<b>To:</b> <a href="mailto:reviews%2BD30526%2Bpublic%2Bc109a870c771c88e@reviews.llvm.org" target="_blank">
reviews+D30526+public+c109a870c771c88e@reviews.llvm.org</a><br>
<b>Cc:</b> <a href="mailto:chandlerc@gmail.com" target="_blank">chandlerc@gmail.com</a>;
<a href="mailto:chris.bieneman@me.com" target="_blank">chris.bieneman@me.com</a>;
<a href="mailto:pavel@labath.sk" target="_blank">pavel@labath.sk</a>; <a href="mailto:jfbastien@apple.com" target="_blank">
jfbastien@apple.com</a>; <a href="mailto:notstina@gmail.com" target="_blank">notstina@gmail.com</a>; Tom Tan <<a href="mailto:Tom.Tan@microsoft.com" target="_blank">Tom.Tan@microsoft.com</a>>;
<a href="mailto:n54@gmx.com" target="_blank">n54@gmx.com</a>; <a href="mailto:dccitaliano@gmail.com" target="_blank">
dccitaliano@gmail.com</a>; <a href="mailto:danalbert@google.com" target="_blank">
danalbert@google.com</a>; <a href="mailto:srhines@google.com" target="_blank">srhines@google.com</a>;
<a href="mailto:emaste@freebsd.org" target="_blank">emaste@freebsd.org</a>; <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">
llvm-commits@lists.llvm.org</a>; <a href="mailto:llvm@inglorion.net" target="_blank">
llvm@inglorion.net</a>; <a href="mailto:sguelton@redhat.com" target="_blank">sguelton@redhat.com</a><br>
<b>Subject:</b> Re: [PATCH] D30526: [Support] Add functions to get and set thread name.<o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">I'm on vacation right now so I don't have a source tree that I can get access to, but if the two files are in the same directory then I think we shouldn't specify the folder name,
and it should just be #include "WindowsSupport.h". Let me know if I'm misunderstood the situation though.<o:p></o:p></p>
</div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">On Wed, Jan 2, 2019 at 4:17 PM Tom Tan via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<p class="MsoNormal" style="mso-margin-top-alt:auto;margin-bottom:12.0pt">TomTan added a comment.<br>
Herald added subscribers: kristina, jfb.<br>
<br>
Hi Zachary, does this line "#include "Windows/WindowsSupport.h" " need to be changed to "#include "WindowsSupport.h" " after it is moved from Threading.cpp to Threading.inc, because Threading.inc which includes WindowsSupport.h is under Windows folder, so no
need to have it in the include path. This current include path could trigger warning "#include resolved using non-portable Microsoft search rules as: ..."<br>
<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD30526%2Fnew%2F&data=02%7C01%7CTom.Tan%40microsoft.com%7Cdfe74d7477b54b29d72108d67118abaa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636820748131392196&sdata=zLuT41MvdXmvkruKuTgFM7qo%2FqgnvI1DgAPmbWsx50s%3D&reserved=0" target="_blank">
https://reviews.llvm.org/D30526/new/</a><br>
<br>
<a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD30526&data=02%7C01%7CTom.Tan%40microsoft.com%7Cdfe74d7477b54b29d72108d67118abaa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636820748131392196&sdata=vXq4vX9NuYK0YmOcZtfC74KmkumWhJpJ7VSXFK15LW8%3D&reserved=0" target="_blank">https://reviews.llvm.org/D30526</a><br>
<br>
<o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</body>
</html>