[PATCH] D56130: Extend Module::getOrInsertGlobal to also take the default arguments accepted by the GlobalVariable constructor.
Chandler Carruth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Dec 29 15:41:33 PST 2018
chandlerc added a comment.
In D56130#1342467 <https://reviews.llvm.org/D56130#1342467>, @philip.pfaffe wrote:
> That solves the default case, but I feel like the new three-argument case is still not much better than getGlobalVariable and an if.
Yeah, it just makes it clear where any future changes like a mutex
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56130/new/
https://reviews.llvm.org/D56130
More information about the llvm-commits
mailing list