[PATCH] D56130: Extend Module::getOrInsertGlobal to also take the default arguments accepted by the GlobalVariable constructor.

Philip Pfaffe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 29 15:32:34 PST 2018

Previous message: [PATCH] D56130: Extend Module::getOrInsertGlobal to also take the default arguments accepted by the GlobalVariable constructor.
Next message: [PATCH] D56130: Extend Module::getOrInsertGlobal to also take the default arguments accepted by the GlobalVariable constructor.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

philip.pfaffe added a comment.

That solves the default case, but I feel like the new three-argument case is still not much better than getGlobalVariable and an if.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56130/new/

https://reviews.llvm.org/D56130

Previous message: [PATCH] D56130: Extend Module::getOrInsertGlobal to also take the default arguments accepted by the GlobalVariable constructor.
Next message: [PATCH] D56130: Extend Module::getOrInsertGlobal to also take the default arguments accepted by the GlobalVariable constructor.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list