[PATCH] D56119: [PowerPC] Fix ADDE, SUBE do not know how to promote operator

[Hal Finkel via Phabricator via llvm-commits]

hfinkel accepted this revision.
hfinkel added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:146
   case ISD::ADDCARRY:
   case ISD::SUBCARRY:    Res = PromoteIntRes_ADDSUBCARRY(N, ResNo); break;
 
----------------
I think that this works, but...

Please add a comment to PromoteIntRes_ADDSUBCARRY stating that it is also handling promotion for the ADDE/SUBE nodes (which differ from the ADDCARRY/SUBCARRY nodes in that the third operand is the input carry flag instead of a carry Boolean).

LGTM.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56119/new/

https://reviews.llvm.org/D56119