[PATCH] D55629: [elfabi] Add support for reading DT_SONAME from binaries

Armando Montanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 21 10:26:09 PST 2018


amontanez updated this revision to Diff 179309.
amontanez marked 2 inline comments as done.
amontanez added a comment.

Changed:

- Mandatory `DynamicEntries` members are now uint64_t instead of Optional<uint64_t>, now include more checks for correctness.
- Bound checking when creating SoName string from .dynstr table.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55629/new/

https://reviews.llvm.org/D55629

Files:
  llvm/test/tools/llvm-elfabi/binary-read-arch.test
  llvm/test/tools/llvm-elfabi/binary-read-bad-soname.test
  llvm/test/tools/llvm-elfabi/binary-read-no-dt-strsz.test
  llvm/test/tools/llvm-elfabi/binary-read-no-dt-strtab.test
  llvm/test/tools/llvm-elfabi/binary-read-no-dynamic.test
  llvm/test/tools/llvm-elfabi/binary-read-soname-no-null.test
  llvm/test/tools/llvm-elfabi/binary-read-soname.test
  llvm/test/tools/llvm-elfabi/binary-read-zero-dt-strsz.test
  llvm/test/tools/llvm-elfabi/binary-read-zero-dt-strtab.test
  llvm/test/tools/llvm-elfabi/replace-soname-tbe.test
  llvm/tools/llvm-elfabi/ELFObjHandler.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55629.179309.patch
Type: text/x-patch
Size: 18186 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181221/4df73ec0/attachment-0001.bin>


More information about the llvm-commits mailing list