[PATCH] D55279: [RISCV] Support assembling %got_pcrel_hi operator

Roger Ferrer Ibanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 21 02:54:13 PST 2018


rogfer01 added inline comments.


================
Comment at: lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp:51
       Asm.getContext().reportError(Fixup.getLoc(),
                                    "could not find corresponding %pcrel_hi");
       return false;
----------------
Should this error message be updated to include `%got_pcrel_hi` too? 

If so, I think we will have to update it again for the forthcoming `%tls_ie_pcrel_hi` and `%tls_gd_pcrel_hi` (not in this change) but in D55342.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55279/new/

https://reviews.llvm.org/D55279





More information about the llvm-commits mailing list