[PATCH] D55325: [RISCV] Add assembler support for LA pseudo-instruction

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

Thanks, this basically looks good to me. Could you please add some tests for la with invalid operands.

Not hugely important, but I do think that adding a FIXME/TODO as Lewis suggests would be worthwhile. It signals to anyone reading the code that they're encountering a known limitation rather than the author failing to consider the requirements of .option pic/nopic.



================
Comment at: test/MC/RISCV/rvi-pseudos.s:37
+# CHECK-NOPIC: addi  a0, a0, %pcrel_lo(.Lpcrel_hi5)
+# CHECK-PIC:       auipc a0, %got_pcrel_hi(a_symbol)
+# CHECK-PIC-RV32: lw    a0, %pcrel_lo(.Lpcrel_hi5)(a0)
----------------
Should strip the unwanted whitespace in this file


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55325/new/

https://reviews.llvm.org/D55325