[PATCH] D55940: Detect incorrect FileCheck variable CLI definition
Joel E. Denny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 20 12:18:47 PST 2018
jdenny added a comment.
In D55940#1337906 <https://reviews.llvm.org/D55940#1337906>, @probinson wrote:
> This will permit `-DVALUE=` (with no value) is that a supported usage?
I think it should be. You could have a string that sometimes appears and sometimes is excluded entirely.
> It also permits `-D=10` which I daresay doesn't mean anything.
Agreed.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55940/new/
https://reviews.llvm.org/D55940
More information about the llvm-commits
mailing list