[PATCH] D55940: Detect incorrect FileCheck variable CLI definition

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

Better diagnostics would definitely be helpful here.

I've also been meaning to make redefinitions an error so that -D isn't the only FileCheck option where order matters.  Currently, earlier definitions have precedence, but that's surely wrong, and I don't see a use case for letting later definitions have precedence.  Care to add that to your patch?

By the way, your summary says FileCheck crashes.  Did you mean it just produces a confusing diagnostic?

Thanks.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55940/new/

https://reviews.llvm.org/D55940