[PATCH] D55902: [ELF] SymbolTable::addShared: don't set IsNeeded unless IsUsedInRegularObj

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: test/ELF/as-needed-not-in-regular.s:2
+# REQUIRES: x86
+
+# RUN: echo '.globl a; .type a, @function; a: ret' | \
----------------
grimar wrote:
> A minor suggestion. I am trying to add a short description to each test
> case I am writing. I.e. about what the purpose, what we do and what we expect.
> It's sometimes really useful because commit log is not always helpful.
> Could you add such comment?
I've already added one " The symbol a is not referenced by a regular object." but I can extend it. Thanks for the reminder.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55902/new/

https://reviews.llvm.org/D55902