[PATCH] D55902: [ELF] SymbolTable::addShared: don't set IsNeeded unless IsUsedInRegularObj
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 20 00:16:22 PST 2018
grimar added inline comments.
================
Comment at: test/ELF/as-needed-not-in-regular.s:2
+# REQUIRES: x86
+
+# RUN: echo '.globl a; .type a, @function; a: ret' | \
----------------
A minor suggestion. I am trying to add a short description to each test
case I am writing. I.e. about what the purpose, what we do and what we expect.
It's sometimes really useful because commit log is not always helpful.
Could you add such comment?
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55902/new/
https://reviews.llvm.org/D55902
More information about the llvm-commits
mailing list