[PATCH] D54889: Fiber support for thread sanitizer

Yuri Per via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 20 08:15:47 PST 2018


yuri added a comment.

In D54889#1334579 <https://reviews.llvm.org/D54889#1334579>, @dvyukov wrote:

> > I added default synchronization and flag to opt-out.
>
> Can you swicth to it in your codebase? I would expect that you need all (or almost all) of this synchronization anyway?


Unfortunately, I can't check it. Current implementation of our codebase work fine with synchronization on fiber switch.

I plan to implement another mode when fibers are not synchronized by default, but only when they call special synchronization APIs (events, mutexes etc.). Such way I can catch more errors in code when fibers are running in the same thread only by chance. In order to implement it, I need some way to opt-out of synchronization in tsan.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54889/new/

https://reviews.llvm.org/D54889





More information about the llvm-commits mailing list