[PATCH] D54889: Fiber support for thread sanitizer

Yuri Per via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 20 08:05:37 PST 2018


yuri marked 13 inline comments as done.
yuri added inline comments.


================
Comment at: lib/tsan/rtl/tsan_rtl.h:885
+void FiberDestroy(ThreadState *fiber, uptr pc);
+void FiberSwitch(ThreadState *fiber, unsigned flags, uptr pc);
+
----------------
dvyukov wrote:
> It seems it should be `SwtchFiberFlags flags`. Or why do we need SwtchFiberFlags?
We can't use enum type of parameter because it is combination of bits. This is done the same way as enum MutexFlags in tsan_sync.h


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54889/new/

https://reviews.llvm.org/D54889





More information about the llvm-commits mailing list