[PATCH] D55909: [ExpandISelPseudos] Recompute liveins after introducing a new MBB.
Tim Northover via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 20 01:55:13 PST 2018
t.p.northover added inline comments.
================
Comment at: lib/CodeGen/ExpandISelPseudos.cpp:75
+ for (MachineInstr &MI : reverse(*MBB)) {
+ for (MachineOperand &MOP : reverse(MI.operands())) {
+ if (!MOP.isReg() ||
----------------
I think the logic needed here is a little more complicated. Fortunately, someone else has already been scarred for life by working it out (I expect) and you can just call `addLiveIns` from `LivePhysRegs.h`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55909/new/
https://reviews.llvm.org/D55909
More information about the llvm-commits
mailing list