[PATCH] D55910: [WebAssembly] Emit a splat for v128 IMPLICIT_DEF

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 19 19:50:57 PST 2018


aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: lib/Target/WebAssembly/WebAssemblyRegStackify.cpp:129
+                      .addImm(0)
+                      .getInstr();
+    LIS.InsertMachineInstrInMaps(*Const);
----------------
You don't need `.getInstr()`; `MachineInstrBuilder` has a [[ https://github.com/llvm-mirror/llvm/blob/d0092eb5f9ff4f2fb000fe20bf3b643aa4803565/include/llvm/CodeGen/MachineInstrBuilder.h#L75 | conversion operator ]] to `MachineInstr *`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55910/new/

https://reviews.llvm.org/D55910





More information about the llvm-commits mailing list