[PATCH] D55910: [WebAssembly] Emit a splat for v128 IMPLICIT_DEF

[Thomas Lively via Phabricator via llvm-commits]

tlively marked an inline comment as done.
tlively added a comment.

In D55910#1337120 <https://reviews.llvm.org/D55910#1337120>, @aheejin wrote:

> - So your intention was to do this even after we support `v128.const`, because it is code size savings, right?


That's right. V8 not supporting v128.const just made it a little more urgent.

> - So there were no assumptions broken after we insert a new instruction after stackification?

Looks like it worked out. The insertion is a local, type-safe change that happens before the registers are stripped and the opcodes changed to their stack forms, so it seems ok.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55910/new/

https://reviews.llvm.org/D55910