[PATCH] D55787: [X86] Use UADDSAT/USUBSAT instead of ADDUS/SUBUS

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 18 04:15:27 PST 2018


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

In D55787#1334280 <https://reviews.llvm.org/D55787#1334280>, @nikic wrote:

> > Thanks - please add the new test files to trunk with current codegen so the patch shows the diff.
>
> I can't commit these as-is, because the fixes for UADDSAT/USUBSAT legalization at least are needed (there will be assertion failures otherwise). Should I commit the tests together with those changes?


LGTM - yes please. The legalization + (current codegen) tests, followed by the improved x86 support and tests codegen.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55787/new/

https://reviews.llvm.org/D55787





More information about the llvm-commits mailing list