[PATCH] D55787: [X86] Use UADDSAT/USUBSAT instead of ADDUS/SUBUS

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 18 04:13:40 PST 2018


lebedev.ri added a comment.

In D55787#1334280 <https://reviews.llvm.org/D55787#1334280>, @nikic wrote:

> > Thanks - please add the new test files to trunk with current codegen so the patch shows the diff.
>
> I can't commit these as-is, because the fixes for UADDSAT/USUBSAT legalization at least are needed (there will be assertion failures otherwise).


Phab has this feature of being able to specify dependencies between the differentials. It is sometimes useful to do that.

> Should I commit the tests together with those changes?

You could at least split the baseline tests into a separate 'parent' differential, and base this differential on that new one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55787/new/

https://reviews.llvm.org/D55787





More information about the llvm-commits mailing list