[PATCH] D55281: debuginfo: Use symbol difference for CU length to simplify assembly reading/editing

Mon Dec 17 12:55:55 PST 2018

ABataev added a comment.

In D55281#1333445 <https://reviews.llvm.org/D55281#1333445>, @dblaikie wrote:

> Hey Alexey - thanks for taking a look!
>
> In D55281#1333365 <https://reviews.llvm.org/D55281#1333365>, @ABataev wrote:
>
> > NVPTX does not support labels in the debug info sections. All these new labels must be created/emitted only if `DwarfDebug::useSectionsAsReferences()` is `false`.
>
>
> Is that the right name for the flag? If you reckon so - though I'm not sure it means a lot to me, personally. (
>
> Also, a few places in lib/CodeGen/AsmPrinter/* use isNVPTX directly, not UseSectionsAsReferences - are they correct? (eg: UseRangeSection, UseInlineStrings, UseLocSection, some test for physical registers in updateSubprogramScopeDIE) What's the difference between these two things?

`useSectionsAsReferences()` does not allow to define inner symbols in the debug sections and force using the section names itself as references in other debug info sections (if it is supported). You need to use this one. Other flags are also required for the NVPTX debug info, but they control different format features.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55281/new/

https://reviews.llvm.org/D55281