[PATCH] D55281: debuginfo: Use symbol difference for CU length to simplify assembly reading/editing

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 17 12:49:37 PST 2018


dblaikie added a comment.

Hey Alexey - thanks for taking a look!

In D55281#1333365 <https://reviews.llvm.org/D55281#1333365>, @ABataev wrote:

> NVPTX does not support labels in the debug info sections. All these new labels must be created/emitted only if `DwarfDebug::useSectionsAsReferences()` is `false`.


Is that the right name for the flag? If you reckon so - though I'm not sure it means a lot to me, personally. (

Also, a few places in lib/CodeGen/AsmPrinter/* use isNVPTX directly, not UseSectionsAsReferences - are they correct? (eg: UseRangeSection, UseInlineStrings, UseLocSection, some test for physical registers in updateSubprogramScopeDIE) What's the difference between these two things?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55281/new/

https://reviews.llvm.org/D55281





More information about the llvm-commits mailing list