[PATCH] D53897: [FileCheck] Annotate input dump (5/7)

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 14 13:18:09 PST 2018


jdenny added a comment.

In D53897#1331556 <https://reviews.llvm.org/D53897#1331556>, @probinson wrote:

> The terminology around "possible" "expected" and "final" matches probably warrants a few lines of commentary somewhere, unless I missed it in an earlier patch.  There are getting to be enough cases that the casual reader (ahem) can't just Zen their way through them all.


Sure, I'll add some additional comments here.

> Can be done as a follow-up if you prefer.

Yes, a follow-up would be easier.  I'll just commit something.  If you prefer a phab review first, that's absolutely fine for me, but let me know.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53897/new/

https://reviews.llvm.org/D53897





More information about the llvm-commits mailing list