[PATCH] D53897: [FileCheck] Annotate input dump (5/7)
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 14 12:57:53 PST 2018
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
The terminology around "possible" "expected" and "final" matches probably warrants a few lines of commentary somewhere, unless I missed it in an earlier patch. There are getting to be enough cases that the casual reader (ahem) can't just Zen their way through them all.
Can be done as a follow-up if you prefer.
One comment nit and LGTM.
================
Comment at: llvm/utils/FileCheck/FileCheck.cpp:418
- // Print numbered line.
+ // For case where -v and colors are enabled, find the annotations for final
+ // matches for expected patterns in order to highlight everything else in
----------------
For the case...
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53897/new/
https://reviews.llvm.org/D53897
More information about the llvm-commits
mailing list