[PATCH] D54487: Implement llvm.commandline named metadata

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 12 12:45:57 PST 2018


scott.linder updated this revision to Diff 177892.
scott.linder marked 5 inline comments as done.
scott.linder added a comment.

Address feedback. The verifier appears to bail on the first failure, at least with llc/llvm-as.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54487/new/

https://reviews.llvm.org/D54487

Files:
  include/llvm/CodeGen/AsmPrinter.h
  include/llvm/CodeGen/TargetLoweringObjectFileImpl.h
  include/llvm/Target/TargetLoweringObjectFile.h
  lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  lib/CodeGen/TargetLoweringObjectFileImpl.cpp
  lib/IR/Verifier.cpp
  test/CodeGen/X86/commandline-metadata.ll
  test/Linker/Inputs/commandline.a.ll
  test/Linker/Inputs/commandline.b.ll
  test/Linker/commandline.ll
  test/Verifier/commandline-meta1.ll
  test/Verifier/commandline-meta2.ll
  test/Verifier/commandline-meta3.ll
  test/Verifier/commandline-meta4.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54487.177892.patch
Type: text/x-patch
Size: 9922 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181212/9885d710/attachment.bin>


More information about the llvm-commits mailing list