[PATCH] D54487: Implement llvm.commandline named metadata

[John Reagan via Phabricator via llvm-commits]

JohnReagan added inline comments.


================
Comment at: lib/CodeGen/TargetLoweringObjectFileImpl.cpp:799
+MCSection *TargetLoweringObjectFileELF::getSectionForCommandLines() const {
+  return getContext().getELFSection(".GCC.command.line", ELF::SHT_PROGBITS,
+                                    ELF::SHF_MERGE | ELF::SHF_STRINGS, 1, "");
----------------
So now that we've switched to a section name with GCC, do you want a comment so any future contributor won't be confused?  If you only look at the code without these review comments (or the corresponding clang edits), you might wonder about the overall design goals.  Something like


```
// Use ".GCC.command.line" since this feature is to support 
// clang's -frecord-gcc-switches which in turn attempts to 
// mimic GCC's switch of the same name.
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54487/new/

https://reviews.llvm.org/D54487