[PATCH] D55593: [gn build] Add all non-test build files for lld

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 12 09:59:15 PST 2018


thakis marked an inline comment as done.
thakis added a comment.

Thanks!



================
Comment at: llvm/utils/gn/secondary/lld/COFF/BUILD.gn:10
+  output_name = "lldCOFF"
+  configs += [ "//llvm/utils/gn/build:lld_code" ]
+  deps = [
----------------
phosek wrote:
> Now that I'm looking at this, it feels a bit awkward for lld config to be in `//llvm/...` rather than something like `//lld:lld_config`.
Happy to move it in a follow-up, just say the word :-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55593/new/

https://reviews.llvm.org/D55593





More information about the llvm-commits mailing list