[PATCH] D55593: [gn build] Add all non-test build files for lld
    Petr Hosek via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Dec 12 09:38:48 PST 2018
    
    
  
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/utils/gn/secondary/lld/COFF/BUILD.gn:10
+  output_name = "lldCOFF"
+  configs += [ "//llvm/utils/gn/build:lld_code" ]
+  deps = [
----------------
Now that I'm looking at this, it feels a bit awkward for lld config to be in `//llvm/...` rather than something like `//lld:lld_config`.
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55593/new/
https://reviews.llvm.org/D55593
    
    
More information about the llvm-commits
mailing list