[PATCH] D54991: Add interceptors for the rmd160(3) from NetBSD

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski marked 2 inline comments as done.
krytarowski added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7378
+  if (state)
+    COMMON_INTERCEPTOR_READ_RANGE(ctx, state, sizeof(u32) * 5);
+  if (buffer)
----------------
vitalybuka wrote:
> vitalybuka wrote:
> > should write something, maybe both
> so why this does not write?
Forgotten, to be fixed.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7362
+  COMMON_INTERCEPTOR_ENTER(ctx, RMD160Update, context, data, len);
+  if (data && len > 0)
+    COMMON_INTERCEPTOR_READ_RANGE(ctx, data, len);
----------------
vitalybuka wrote:
> Is there any issues with COMMON_INTERCEPTOR_READ_RANGE when len is 0?
> 
at least it's waste operation and doesn't make sense


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54991/new/

https://reviews.llvm.org/D54991