[PATCH] D54991: Add interceptors for the rmd160(3) from NetBSD

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 7 16:02:56 PST 2018


vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7378
+  if (state)
+    COMMON_INTERCEPTOR_READ_RANGE(ctx, state, sizeof(u32) * 5);
+  if (buffer)
----------------
vitalybuka wrote:
> should write something, maybe both
so why this does not write?


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7362
+  COMMON_INTERCEPTOR_ENTER(ctx, RMD160Update, context, data, len);
+  if (data && len > 0)
+    COMMON_INTERCEPTOR_READ_RANGE(ctx, data, len);
----------------
Is there any issues with COMMON_INTERCEPTOR_READ_RANGE when len is 0?



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54991/new/

https://reviews.llvm.org/D54991





More information about the llvm-commits mailing list