[PATCH] D55344: Support skewed Stream Arrays

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added inline comments.


================
Comment at: llvm/lib/DebugInfo/PDB/Native/ModuleDebugStream.cpp:50
     return EC;
-  if (auto EC = Reader.readSubstream(SymbolsSubstream, SymbolSize - 4))
+  Reader.setOffset(0);
+  if (auto EC = Reader.readSubstream(SymbolsSubstream, SymbolSize))
----------------
Maybe a one-line explanation would be needed here too? To explain why we're reading the Signature, then reseting, the reading the whole stream?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55344/new/

https://reviews.llvm.org/D55344