[PATCH] D55344: Support skewed Stream Arrays

[Alexandre Ganea via Phabricator via llvm-commits]

aganea accepted this revision.
aganea added a comment.
This revision is now accepted and ready to land.

LGTM, thank you for cleaning that up!



================
Comment at: llvm/lib/DebugInfo/PDB/Native/ModuleDebugStream.cpp:60
+  if (auto EC = SymbolReader.readArray(
+          SymbolArray, SymbolReader.bytesRemaining(), sizeof(uint32_t)))
     return EC;
----------------
Could you please indicate in a comment what `sizeof(uint32_t)` refers to? Eg.
```
  if (auto EC = SymbolReader.readArray(
          SymbolArray, SymbolReader.bytesRemaining(), /*skip Signature*/ sizeof(uint32_t)))
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55344/new/

https://reviews.llvm.org/D55344