[PATCH] D54143: [WIP, RISCV] Generate address sequences suitable for mcmodel=medium

James Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 5 02:22:37 PST 2018


jrtc27 added inline comments.


================
Comment at: lib/Target/RISCV/RISCVExpandPseudoInsts.cpp:85
 
+bool RISCVExpandPseudo::expandAddrPCRel(MachineBasicBlock &MBB,
+                                        MachineBasicBlock::iterator MBBI,
----------------
This should come at the end of the file just after `expandAtomicCmpXchg` to match the order in which they're declared above (and once using `PseudoLLA` instead, be called `expandLoadLocalAddress` or similar).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54143/new/

https://reviews.llvm.org/D54143





More information about the llvm-commits mailing list