[PATCH] D55237: LTO: Don't internalize available_externally globals.
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 4 16:10:08 PST 2018
pcc added inline comments.
================
Comment at: llvm/lib/LTO/LTO.cpp:362
!GlobalValue::isLocalLinkage(S->linkage()) &&
- !GlobalValue::isAppendingLinkage(S->linkage()))
+ S->linkage() != GlobalValue::AppendingLinkage &&
+ // We can't internalize available_externally globals because this
----------------
tejohnson wrote:
> This change seems unnecessary?
Just making it consistent with the code I'm adding below.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55237/new/
https://reviews.llvm.org/D55237
More information about the llvm-commits
mailing list