[PATCH] D55237: LTO: Don't internalize available_externally globals.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 4 16:05:15 PST 2018


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

Lgtm



================
Comment at: llvm/lib/LTO/LTO.cpp:362
                !GlobalValue::isLocalLinkage(S->linkage()) &&
-               !GlobalValue::isAppendingLinkage(S->linkage()))
+               S->linkage() != GlobalValue::AppendingLinkage &&
+               // We can't internalize available_externally globals because this
----------------
This change seems unnecessary?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55237/new/

https://reviews.llvm.org/D55237





More information about the llvm-commits mailing list