[PATCH] D55228: [PDB] Emit S_UDT records in LLD

[Zachary Turner via Phabricator via llvm-commits]

zturner updated this revision to Diff 176680.
zturner added a comment.

Changed the test to an llvm assembly test, and properly handle collisions.  I actually added some instrumentation to detect if any collisions were actually occurring, and I did not find any with a PDB containing 450,000 S_UDT records.  On the other hand, I did not measure a performance impact from adding this, so I'm adding it anyway.  We can revisit later if it shows up on a profile.

Note that the test changed a little bit.  For some reason, when I use an IR test and llc it generates different assembly than if I use an assembly test with llvm-mc.  I don't know if this is normal, but throwing it out there just in case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55228/new/

https://reviews.llvm.org/D55228

Files:
  lld/COFF/PDB.cpp
  lld/test/COFF/pdb-globals.test
  lld/test/COFF/pdb-symbol-types.yaml
  lld/test/COFF/pdb-type-server-simple.test
  lld/test/COFF/s_udt.s
  llvm/include/llvm/DebugInfo/PDB/Native/GSIStreamBuilder.h
  llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55228.176680.patch
Type: text/x-patch
Size: 24626 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181204/30e669ef/attachment-0001.bin>