[PATCH] D55228: [PDB] Emit S_UDT records in LLD
Zachary Turner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 3 14:12:56 PST 2018
zturner added a comment.
Yea he's right, I was just having a brain fail when I wrote that. I'm updating the code to correctly handle collisions. I don't think we need to do anything special for `S_CONSTANT` though, because the `DenseSet<>` is just holding hash values of generic `CVSymbol` records, which could be any kind of symbol, including `S_CONSTANT`. With a record-kind-agnostic hash set and the ability to handle collisions, we just need to change the if statement to a switch statement and we can handle all the types we want.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55228/new/
https://reviews.llvm.org/D55228
More information about the llvm-commits
mailing list