[PATCH] D55252: fix PointerIntPair visualizer

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 4 02:19:16 PST 2018


Lgtm
On Mon, Dec 3, 2018 at 10:59 PM Trass3r via Phabricator <
reviews at reviews.llvm.org> wrote:

> Trass3r created this revision.
> Trass3r added a reviewer: zturner.
> Herald added a subscriber: llvm-commits.
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D55252
>
> Files:
>   utils/LLVMVisualizers/llvm.natvis
>
>
> Index: utils/LLVMVisualizers/llvm.natvis
> ===================================================================
> --- utils/LLVMVisualizers/llvm.natvis
> +++ utils/LLVMVisualizers/llvm.natvis
> @@ -85,10 +85,10 @@
>    </Type>
>
>    <Type Name="llvm::PointerIntPair<*,*,*,*>">
> -    <DisplayString>{IntMask}: {($T1)(Value & PointerBitMask)}
> [{($T3)((Value >> IntShift) & IntMask)}]</DisplayString>
> +    <DisplayString>{$T5::IntMask}: {($T1)(Value &
> $T5::PointerBitMask)} [{($T3)((Value >> $T5::IntShift) &
> $T5::IntMask)}]</DisplayString>
>      <Expand>
> -      <Item Name="[ptr]">($T1)(Value & PointerBitMask)</Item>
> -      <Item Name="[int]">($T3)((Value >> IntShift) &
> IntMask)</Item>
> +      <Item Name="[ptr]">($T1)(Value & $T5::PointerBitMask)</Item>
> +      <Item Name="[int]">($T3)((Value >> $T5::IntShift) &
> $T5::IntMask)</Item>
>      </Expand>
>    </Type>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181204/aa0c588f/attachment.html>


More information about the llvm-commits mailing list