[PATCH] D54594: Add new interceptors for vis(3) API in NetBSD

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7382
+  if (dst && end)
+    COMMON_INTERCEPTOR_WRITE_RANGE(ctx, dst,
+                                   Min((SIZE_T)(end - dst + 1), dlen));
----------------
> The functions nvis() and snvis() will return NULL and the functions
> strnvis(),	strnvisx(), strsnvis(),	and strsnvisx(), will return -1	when
> the dlen destination buffer size is not enough to perform the conversion

I read this that it's always null terminated or (null or -1), so Min is not needed

And the same for the rest


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54594/new/

https://reviews.llvm.org/D54594