[PATCH] D54594: Add new interceptors for vis(3) API in NetBSD

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7318
+  // The interface will be valid even if there is no space for NULL char
+  if (dst && len >= 0)
+    COMMON_INTERCEPTOR_WRITE_RANGE(ctx, dst,
----------------
vitalybuka wrote:
> len >= 0 is always true, it's unsigned type
> 
len is signed


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7523
+  COMMON_INTERCEPT_FUNCTION(strvisx);                                          \
+  COMMON_INTERCEPT_FUNCTION(strnvisx);                                         \
+  COMMON_INTERCEPT_FUNCTION(strenvisx);                                        \
----------------
vitalybuka wrote:
> they are so similar, is any idea how to minimize code size?
Actually not and they differ in one way or another.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54594/new/

https://reviews.llvm.org/D54594