[PATCH] D55045: Add a version of std::function that includes a few optimizations.
    Jordan Soyke via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Dec  3 21:53:50 PST 2018
    
    
  
jsoyke marked an inline comment as done.
jsoyke added inline comments.
================
Comment at: include/functional:2236
+        *this = nullptr;
+        function(_VSTD::move(__f)).swap(*this);
     }
----------------
This causes a regression in the non-optimized version, presumably because swap() has a lot of conditionals and potential out-of-line calls, I'll fix this if the new code structure looks good otherwise.
Repository:
  rCXX libc++
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55045/new/
https://reviews.llvm.org/D55045
    
    
More information about the llvm-commits
mailing list