[PATCH] D55045: Add a version of std::function that includes a few optimizations.
    Jordan Soyke via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Dec  3 21:49:22 PST 2018
    
    
  
jsoyke marked 2 inline comments as done.
jsoyke added inline comments.
================
Comment at: include/functional:1486
+
+  _LIBCPP_INLINE_VISIBILITY
+  explicit __func(_Target&& __f)
----------------
Let me know if I'm using this macro correctly. It seems like it should be present on all non-public symbols?
================
Comment at: include/functional:1535
 template<class _Rp, class ..._ArgTypes>
-class __base<_Rp(_ArgTypes...)>
+class __vfunc<_Rp(_ArgTypes...)>
 {
----------------
No strong feelings on any of the class names I've used here. I was thinking vfunc = vtable based and pfunc = policy based, but I'd be fine with something more descriptive as well.
Repository:
  rCXX libc++
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55045/new/
https://reviews.llvm.org/D55045
    
    
More information about the llvm-commits
mailing list