[PATCH] D55156: [asan] Rename -asan-use-private-alias to -asan-use-odr-indicator

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

In D55156#1316695 <https://reviews.llvm.org/D55156#1316695>, @m.ostapenko wrote:

> Hm, I'd rather separate private aliases and odr indicators because they are separate (although connected) features:


I'll do this.

> 
> 
> - Private aliases are used to avoid ASan false positives when we mix instrumented and non-instrumented modules (also, AFAIR, FPs are possible when using LTO). They can be used with and without ODR indicators.
> - ODR indicators were introduced to improve ODR violation in presence of private aliases, but they can be omitted if desired.

Can you please elaborate on how it improves "use_odr_indicator"? Do we miss some violations if we "have aliases without indicators" comparing to default:"have no aliases and have no indicators"?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55156/new/

https://reviews.llvm.org/D55156