[PATCH] D55156: [asan] Rename -asan-use-private-alias to -asan-use-odr-indicator

Maxim Ostapenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 3 06:54:10 PST 2018


m.ostapenko added a comment.

Hm, I'd rather separate private aliases and odr indicators because they are separate (although connected) features:

- Private aliases are used to avoid ASan false positives when we mix instrumented and non-instrumented modules (also, AFAIR, FPs are possible when using LTO). They can be used with and without ODR indicators.
- ODR indicators were introduced to improve ODR violation in presence of private aliases, but they can be omitted if desired.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55156/new/

https://reviews.llvm.org/D55156





More information about the llvm-commits mailing list